On Fri, 20 Mar 2026 19:30:18 GMT, Lance Andersen <[email protected]> wrote:

> The IAE is thrown from writeLOC vs writeCEN (due to closing the Zip)
> 
> Question is do we want to remove the use of try/with/resources or leave as is?
> 
> With your change it might not matter though but wanted to throw it out there

With the try-with-resources in place, we excercise the close and verifies that 
any validation exception is throw from `putNextEntry` and only then. 

If we don't call close (explicitly or implicitly) then we won't neccessarily 
catch a regression where decoding the name fails first in putNextEntry, then in 
close.

Do you think this makes sense?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30319#discussion_r2968040426

Reply via email to