On Fri, 20 Mar 2026 16:55:26 GMT, Eirik Bjørsnøs <[email protected]> wrote:
>> Please review this PR which updates the specification of >> `ZipOutputStream.setComment(String)` to match the long-standing behavior of >> throwing `IllegalArgumentException` when a comment contains characters which >> are unmappable using the `Charset` passed in the constructor. >> >> A new tests is added to reproduce calling setComment with unmappable >> characters and verify that it throws IAE. >> >> A CSR has been drafted. Its specification section will be updated after an >> initial round of review of the specification text in this PR. > > Eirik Bjørsnøs has updated the pull request incrementally with one additional > commit since the last revision: > > Add note to @param comment specification that the comment may be set to > null or the empty string to produce no ZIP file comment test/jdk/java/util/zip/ZipOutputStream/UnmappableZipFileComment.java line 32: > 30: > 31: import static java.io.OutputStream.nullOutputStream; > 32: import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; Import for `assertDoesNotThrow` is unused? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30338#discussion_r2968066409
