On Tue, 24 Mar 2026 13:41:45 GMT, Per Minborg <[email protected]> wrote:
>> Implement JEP 531: Lazy Constants (Third Preview) >> >> This PR replaces _draft_ https://github.com/openjdk/jdk/pull/29507 > > Per Minborg has updated the pull request incrementally with two additional > commits since the last revision: > > - Improve IR test > - Strenghten contention tests Thank you for addressing my comments. My suggestion for the driver VM was unfortunately misguided in combination with enabled preview. Apologies. test/hotspot/jtreg/compiler/stable/LazyConstantsIrTest.java line 26: > 24: /* > 25: * @test > 26: * @summary Check LazyConstant and lazy collection coinstant folding Suggestion: * @summary Check LazyConstant and lazy collection constant folding test/hotspot/jtreg/compiler/stable/LazyConstantsIrTest.java line 29: > 27: * @modules java.base/jdk.internal.lang > 28: * @library /test/lib / > 29: * @run driver ${test.main.class} For me, this does not work locally. The following works and matches what we do with IR tests in Valhalla. Suggestion: * @enablePreview * @run main ${test.main.class} ------------- Changes requested by mhaessig (Committer). PR Review: https://git.openjdk.org/jdk/pull/30194#pullrequestreview-3999500527 PR Review Comment: https://git.openjdk.org/jdk/pull/30194#discussion_r2981851028 PR Review Comment: https://git.openjdk.org/jdk/pull/30194#discussion_r2981863877
