> Move validation of the value of the "--mac-package-identifier" option to the > "cli" package. > > If the user supplies an invalid bundle identifier value on the command line, > jpackage will issue error: > > Error: The value "foo_bar" provided for parameter --mac-package-identifier is > not a valid macOS bundle identifier. > Advice to fix: Bundle identifier must be a non-empty string containing only > alphanumeric characters (A-Z, a-z, and 0-9), hyphens (-), and periods (.). > > instead of: > > Error: Invalid mac bundle identifier [foo_bar]. > Advice to fix: specify identifier with "--mac-package-identifier". > > > If "--mac-package-identifier" option is not specified and jpackage fails to > derive a valid bundle identifier from the input data, it will issue the > following error: > > Error: Can't derive a valid bundle identifier from the input data > Advice to fix: Specify bundle identifier with --mac-package-identifier option > > > Added corresponding unit tests. > > Updated MacPropertiesTest test to cover the case when the value of the bundle > identifier is not specified on the command line.
Alexey Semenyuk has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8371182: [macos] Improve error messages for "invalid mac bundle identifier" ------------- Changes: - all: https://git.openjdk.org/jdk/pull/30413/files - new: https://git.openjdk.org/jdk/pull/30413/files/ef1224df..058e8cf0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=30413&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=30413&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/30413.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/30413/head:pull/30413 PR: https://git.openjdk.org/jdk/pull/30413
