On Tue, 24 Mar 2026 19:35:17 GMT, Alexey Semenyuk <[email protected]> wrote:
> Move validation of the value of the "--mac-package-identifier" option to the > "cli" package. > > If the user supplies an invalid bundle identifier value on the command line, > jpackage will issue error: > > Error: The value "foo_bar" provided for parameter --mac-package-identifier is > not a valid macOS bundle identifier. > Advice to fix: Bundle identifier must be a non-empty string containing only > alphanumeric characters (A-Z, a-z, and 0-9), hyphens (-), and periods (.). > > instead of: > > Error: Invalid mac bundle identifier [foo_bar]. > Advice to fix: specify identifier with "--mac-package-identifier". > > > If "--mac-package-identifier" option is not specified and jpackage fails to > derive a valid bundle identifier from the input data, it will issue the > following error: > > Error: Can't derive a valid bundle identifier from the input data > Advice to fix: Specify bundle identifier with --mac-package-identifier option > > > Added corresponding unit tests. > > Updated MacPropertiesTest test to cover the case when the value of the bundle > identifier is not specified on the command line. This pull request has now been integrated. Changeset: 274f8e60 Author: Alexey Semenyuk <[email protected]> URL: https://git.openjdk.org/jdk/commit/274f8e601c60fe48c6dc0fe113c44dc253cd757b Stats: 494 lines in 15 files changed: 416 ins; 32 del; 46 mod 8371182: [macos] Improve error messages for "invalid mac bundle identifier" Reviewed-by: almatvee ------------- PR: https://git.openjdk.org/jdk/pull/30413
