On Tue, 24 Mar 2026 14:44:06 GMT, Chen Liang <[email protected]> wrote:

> VectorMask and VectorShuffle should be marked so too.

Good catch! I added `@ValueBased` to all of `VectorMask` and `VectorShuffle` 
implementations, and re-run `gen-src.sh`.

> We need such an excerpt in every immediately annotated classes:

Indeed.
AFAICS following classes (or their `final` implementations) should have 
`@ValueBased`. Most of classes are FFM related classes, but I haven't yet find 
out what should be treated.


java.base/share/classes/java/lang/foreign/AddressLayout.java
java.base/share/classes/java/lang/foreign/FunctionDescriptor.java
java.base/share/classes/java/lang/foreign/GroupLayout.java
java.base/share/classes/java/lang/foreign/MemoryLayout.java
java.base/share/classes/java/lang/foreign/PaddingLayout.java
java.base/share/classes/java/lang/foreign/SequenceLayout.java
java.base/share/classes/java/lang/foreign/StructLayout.java
java.base/share/classes/java/lang/foreign/UnionLayout.java
java.base/share/classes/java/lang/foreign/ValueLayout.java
java.base/share/classes/java/lang/foreign/MemorySegment.java
java.base/share/classes/java/lang/foreign/Linker.java
java.base/share/classes/java/util/HexFormat.java
java.base/share/classes/jdk/internal/foreign/FunctionDescriptorImpl.java
java.base/share/classes/jdk/internal/foreign/layout/ValueLayouts.java

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30392#issuecomment-4123617041

Reply via email to