On Wed, 25 Mar 2026 01:52:30 GMT, Xiaohong Gong <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reveiw comments resolutions
>
> src/hotspot/share/opto/vectornode.cpp line 1308:
>
>> 1306: if (!is_commutative_vector_operation(Opcode())) {
>> 1307: return nullptr;
>> 1308: }
>
> Seems we need also consider the predicated version of the node here? Can we
> check the predicated feature for a node inside
> `is_commutative_vector_operation()`? This is reasonable since a binary
> operations is not commutative if it has the mask input.
Thanks addressed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25617#discussion_r2986786390
