On Wed, 25 Mar 2026 22:25:19 GMT, Alexander Matveev <[email protected]> 
wrote:

>> Alexey Semenyuk has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Update the wording
>
> test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/cli/help-windows.txt
>  line 205:
> 
>> 203:           Adds a dialog if at least one of --win-menu or --win-shortcut
>> 204:           are specified to enable the user to choose if these shortcuts
>> 205:           will be created by the installer
> 
> I do not have access to Windows machine right now, but I assume this is order 
> we display CLI commands and description. Should we move 
> `--win-per-user-install` after `--win-shortcut-prompt`. It will be more 
> logically since `--win-shortcut-prompt` is related to `--win-menu`, 
> `--win-menu-group`, `--win-shortcut`.

Options are alphabetically ordered.

Help output on all supported platforms is captured in the following 
auto-generated files:
 - 
[help-windows.txt](https://github.com/openjdk/jdk/blob/master/test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/cli/help-windows.txt)
 - 
[help-linux.txt](https://github.com/openjdk/jdk/blob/master/test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/cli/help-linux.txt)
 - 
[help-macos.txt](https://github.com/openjdk/jdk/blob/master/test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/cli/help-macos.txt)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30419#discussion_r2991596756

Reply via email to