On Wed, 25 Mar 2026 22:08:14 GMT, Alexey Semenyuk <[email protected]> wrote:

>> Update description of some Windows options
>
> Alexey Semenyuk has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Update the wording

Looks good, but I am confused about "." usage. Some of our command descriptions 
do have it and some do not.

src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties
 line 409:

> 407: help.option.win-menu=\
> 408: \          Adds a Start menu shortcut for this application, or 
> requests\n\
> 409: \          to do so if --win-shortcut-prompt is specified

Do we need "." at the end similar to `help.option.win-dir-chooser`?

src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties
 line 416:

> 414: help.option.win-per-user-install=\
> 415: \          Installs the application on a per-user basis.\n\
> 416: \          Without this option installs per-machine

I think it needs ".".

-------------

PR Review: https://git.openjdk.org/jdk/pull/30419#pullrequestreview-4010223538
PR Review Comment: https://git.openjdk.org/jdk/pull/30419#discussion_r2991378415
PR Review Comment: https://git.openjdk.org/jdk/pull/30419#discussion_r2991384581

Reply via email to