On Thu, 26 Mar 2026 00:52:34 GMT, Alexander Matveev <[email protected]>
wrote:
> - Removed check on macOS to allow version to start with 0.
> - This is legacy check and it is not clear why such limitation was added.
Looks good overall.
It is missing test coverage for this new behavior, though.
Adding the following code block to `AppVersionTest.testApp()` method should do
it:
if (TKit.isOSX()) {
// Ensure "0.1" is a valid version on macOS.
AppTestSpec.create(TestSpec.build()
.versionFromAppModule("com.other/[email protected]")
.versionFromCmdline("0.1"), testCases::add);
}
-------------
Changes requested by asemenyuk (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/30442#pullrequestreview-4010939328
