On Thu, 26 Mar 2026 16:51:26 GMT, Brian Burkhalter <[email protected]> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Implement review feedback.
>
> test/jdk/jdk/incubator/vector/BasicFloat16ArithTests.java line 150:
> 
>> 148: 
>> 149:         checkFloat16(MIN_VALUE,  MIN_VAL_FP16, "Float16.MIN_VALUE");
>> 150:         checkFloat16(MIN_NORMAL, 0x1.0p-14f,   "Float16.MIN_NORMAL");
> 
> Should `0x1.0p-14f` also be a constant (`MIN_NORM_FP16`?)?

Good idea -- updated; thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30378#discussion_r2996409001

Reply via email to