On Wed, 6 May 2026 21:50:28 GMT, Vladimir Ivanov <[email protected]> wrote:
> It looks reasonable (and performance improvements are impressive for such a > small code generation change). > > It would be nice to enhance ADLC to support such matcher tweaks. They don't > look pretty when coded explicitly... > > I'll submit it for testing. Thank you so much for your valuable feedback and testing! I completely agree that enhancing ADLC/matcher would be the better approach for handling similar cases. I explored fixing this at the matcher level by preventing `all_ones_vector` from being forced into a register, then avoiding duplicate mach nodes by storing them in the `_shared_nodes` map—similar to how scalar constants are handled. However, vector constants introduce additional complexities that differ from scalar constants and require further consideration. ------------- PR Comment: https://git.openjdk.org/jdk/pull/30013#issuecomment-4393864646
