Re: RFR: 8384505: Account for all jtreg-based frames in stack walk test [v2]

[Alan Bateman]

On Wed, 13 May 2026 08:56:14 GMT, Christian Stein <cst...@openjdk.org> wrote:

>> test/jdk/java/lang/StackWalker/StackWalkTest.java line 137:
>> 
>>> 135:                 if (sf.getClassName().startsWith(prefix))
>>> 136:                 // safe to ignore
>>> 137:                 return;
>> 
>> This looks okay and should be okay as long as the the 
>> com.sun.javatest.regtest package continues to be used. I assume you'll fix 
>> the indentation of the if-statement as to early return is only when the 
>> condition is true. 
>> 
>> (As regards the var usage then it's not immediately obvious if prefix is a 
>> String or Package without looking at the declaration of 
>> infrastructurePackages. So I'd probably put the String type here.)
>
> Addressed in 
> https://github.com/openjdk/jdk/pull/31144/commits/16dc66b8e3a7b62d9c5cebbeca409a4a54c362f7

thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31144#discussion_r3233113257