On Thu, 14 May 2026 14:35:50 GMT, Andrew Dinn <[email protected]> wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added AOT Code Cache related code + some cosmetic changes > > src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 7733: > >> 7731: // This function computes partial results of eight 52 x 52 bit >> multiplications, >> 7732: // where the multiplicands are stored as 64-bit values, specifically >> 7733: // (b_0, b_1, b_2, b_3) * (a_3, a_4). > > Should this not be `(a_0, a_1)`? Yes. Fixed. > src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 7902: > >> 7900: __ mov(c_i, high); >> 7901: >> 7902: vs_shl(D, __ T2D, D, 12); > > Suggestion: > > vs_shl(D, __ T2D, D, montMulP256Shift1); Changed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30941#discussion_r3247446626 PR Review Comment: https://git.openjdk.org/jdk/pull/30941#discussion_r3247448007
