On Fri, 15 May 2026 13:04:12 GMT, Thomas Stuefe <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix CDSPlugin and CDSPluginTest, and VMOptionWarning.java test also.
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/CDSPlugin.java
> line 110:
>
>> 108:
>> 109: // The targetPlatform is the same as the runtimePlatform.
>> 110: // For a 64-bit platform, generate the non-compressed oop
>> CDS archive
>
> Comment is outdated, since now we generate all of the archives.
Fixed now.
> test/jdk/tools/jlink/plugins/CDSPluginTest.java line 90:
>
>> 88: helper.checkImage(image, module, null, null,
>> 89: new String[] { subDir + "classes" + suffix });
>> 90: }
>
> For a future RFE: Arguably, this test should test all 4 generated CDS
> archives now.
It has a further fix when we add preview features (valhalla). I'll fix it then.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30322#discussion_r3253113360
PR Review Comment: https://git.openjdk.org/jdk/pull/30322#discussion_r3253115236
