On Tue, 19 May 2026 23:48:31 GMT, Ashay Rane <[email protected]> wrote:
> Although the original implementation of `JLI_Open()` borrowed from the > code in src/hotspot/os/windows/os_windows.cpp, the improvements to > os_windows.cpp don't seem to have been applied to java_md.c, causing > some tests to fail when the path to JAR files is longer than `MAXPATH` > (i.e. 260) characters on Windows (see associated JBS issue 8385024 for > details). Since `JLI_Open()` is not just invoked inside tests, this is > not a test-specific issue, so fixing the test is not the right solution. > > This patch applies the recent changes from os_windows.cpp to java_md.c > so that `JLI_Open()` can correctly handle longer than `MAXPATH` paths. > The new code is almost the same as that in `wide_abs_unc_path()` in > os_windows.cpp, except that the code in java_md.c uses `JLI_MemAlloc()` > and `JLI_MemFree()` for memory allocation and deallocation. > > Although it would be ideal to have just one implementation between > HotSpot and the launcher, the dependencies of the two components > prevents us from having a single implementation. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). src/java.base/windows/native/libjli/java_md.c line 567: > 565: int needs_fullpath = 1; > 566: const wchar_t* prefix = NULL; > 567: set_path_prefix(path, &prefix, &prefix_off, &needs_fullpath); One thing to think about is if normalization needs to be done before adding the prefix as the prefix will turn off checking at use-sites. Can you try an example with `-jar` specifying a file path that has a forward slash in the file path? I think that will help to see if it needs to normalize first. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31209#discussion_r3281496276
