On Tue, 19 May 2026 13:24:01 GMT, Andrew Dinn <[email protected]> wrote:
>> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 7939: >> >>> 7937: vs_addv(D, __ T2D, D, B); >>> 7938: >>> 7939: vs_st1_interleaved(A, D, mul_ptr); >> >> Suggestion: >> >> // interleaved write outputs 8 successive (low, high) 56-bit pairs >> vs_st1_interleaved(A, D, mul_ptr); > > Actually, I see now that my comment was not correct. The write interleaves 4 > successive pairs of low values with four pairs of successive high values i.e. > (low0, low1) (high0, high1) . . . > Suggestion: > > // the write interleaves the 4 successive pairs of low and > // high results: (l0, l1), (h0, h1), ... (l6, l7), (h6, h7) > vs_st1_interleaved(A, D, mul_ptr); Yes. Accepted ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30941#discussion_r3288519651
