On Wed, 20 May 2026 07:48:53 GMT, Aleksey Shipilev <[email protected]> wrote:
> Should these new stubs be AOT-saved/restored? See how other stubs are doing
> `load_archive_data` / `save_archive_data` dance.
Yes, thanks. Done.
> A few drive-by comments. I have not dug into the core of the implementation.
>
> How would you test this for correctness?
We already have tests. E.g. "
make test "jtreg:open/test/jdk/sun/security/ec/ECDSAPrimitive.java"
tests correctness.
@adinn thanks a lot for the thorough review. Unfortunately, from May 26th to
June 10th I will not be able to work on this, so, please take that into
consideration with the re-review.
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 8018:
>
>> 8016: __ ldr(c_i, c_ptr);
>> 8017:
>> 8018: // Limb 1
>
> The numbering is a bit off here. There are duplicate `// Limb 2` comments.
> Should this one be `// Limb 0`?
Fixed.
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 8183:
>
>> 8181: tmp2 = *common_regs++,
>> 8182: tmp3 = *common_regs++,
>> 8183: tmp4 = *common_regs++;
>
> Cannot quite see where these `tmp*`-s are used?
Nowhere. Deleted them.
> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 462:
>
>> 460: if (FLAG_IS_DEFAULT(UseIntPolyIntrinsics)) {
>> 461: UseIntPolyIntrinsics = true;
>> 462: }
>
> Indenting is a bit off here. Also, should this depend on `CPU_ASIMD`, like
> ChaCha20 intrinsic enablement a few blocks above?
It is Intellij's fault :-) . Fixed.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/30941#issuecomment-4518944273
PR Review Comment: https://git.openjdk.org/jdk/pull/30941#discussion_r3288554269
PR Review Comment: https://git.openjdk.org/jdk/pull/30941#discussion_r3288555846
PR Review Comment: https://git.openjdk.org/jdk/pull/30941#discussion_r3288552061
