On Wed, 20 May 2026 08:02:58 GMT, Quan Anh Mai <[email protected]> wrote:
>> Hi, >> >> I was reminded of this forgotten PR when reviewing a counted loop >> transformation PR. The important point is that it is easier and more >> efficient to compute the trip count of a counted loop using unsigned >> division. Currently, for int counted loops, trip count is computed by >> extending the loop parameters to long and doing a signed long division. This >> cannot be applied to long counted loop. As a result, as a precondition for >> long counted loop predication, we need to be able to efficiently transform >> an unsigned division by constant. >> >> For more information, please refer to #9947 . >> >> Testing: >> >> - [x] tier1-4,hs-comp-stress >> >> Please take a look and leave your review, thanks a lot. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Quan Anh Mai has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 100 commits: > > - Fix comments, remove dead code > - Merge branch 'master' into unsignedDiv > - Various fixes > - Fix IntegerDivValueTests > - Fix merge conflicts > - Merge branch 'master' into unsignedDiv > - Merge branch 'master' into unsignedDiv > - fix tests > - Merge branch 'master' into unsignedDiv > - further clarify variable meanings > - ... and 90 more: https://git.openjdk.org/jdk/compare/45e66b6a...e991bb28 test/micro/org/openjdk/bench/java/lang/IntegerDivMod.java line 27: > 25: import java.util.concurrent.TimeUnit; > 26: import java.util.random.RandomGeneratorFactory; > 27: Same question here as well. test/micro/org/openjdk/bench/java/lang/LongDivMod.java line 27: > 25: import java.util.concurrent.TimeUnit; > 26: import java.util.random.RandomGeneratorFactory; > 27: Is there a reason for changing the order of these imports? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31033#discussion_r3292510280 PR Review Comment: https://git.openjdk.org/jdk/pull/31033#discussion_r3292511765
