On Sat, 23 May 2026 01:12:25 GMT, Alexander Matveev <[email protected]> 
wrote:

> - To avoid issues with `osascript` timeouts during testing DMG Script from 
> `jpackage` will be overwritten by no-op script.
> - If -Djpackage.test.SQETest=yes is specified DMG script will not be 
> overwritten.
> 
> 
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java line 
2046:

> 2044:         }
> 2045: 
> 2046:         final String scriptName = appName + "-dmg-setup.scpt";

Can this be simplified down to

String baseName;
try {
    baseName = installerName();
} catch (RuntimeException _) {
    return;
}

final String scriptName = baseName + "-dmg-setup.scpt";

?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31265#discussion_r3305727880

Reply via email to