On Wed, 27 May 2026 03:20:49 GMT, Phil Race <[email protected]> wrote:
>> This removes the remaining uses of AppContext and AppContext itself. >> >> Some tests needed to be removed. Some seemed possibly still useful if I >> removed AppContext. >> >> The source code changes are fairly straightforward - almost entirely just >> deletions. >> >> The only interesting question is where to call SunToolkit.initEQ() >> It was usually initialized via the AppContext creation which isn't possible >> any more. >> >> The EQ can - in theory - be created lazily. >> But because the EQ needs to be created before any events are posted there >> aren't many places to choose from. >> I've put it in the SunToolkit constructor, and it is also - of course - >> still initialized in the static method to get the EQ. >> In postEvent() itself was the only other option that worked but then it is >> checked *every* time an event is posted. >> One of the 2 above seems to be always needed to cover all paths. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8385347 Marked as reviewed by azvegint (Reviewer). test/jdk/java/awt/Dialog/JaWSTest.java line 137: > 135: System.err.println("After Notify"); > 136: } > 137: System.err.println("Stop Running"); The indentation looks uneven. ------------- PR Review: https://git.openjdk.org/jdk/pull/31262#pullrequestreview-4372186175 PR Review Comment: https://git.openjdk.org/jdk/pull/31262#discussion_r3310663139
