On Wed, 27 May 2026 23:50:21 GMT, Alexander Matveev <[email protected]> wrote:
>> - To avoid issues with `osascript` timeouts during testing DMG Script from >> `jpackage` will be overwritten by no-op script. >> - If -Djpackage.test.SQETest=yes is specified DMG script will not be >> overwritten. >> >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8382025: [lworld] tools/jpackage/share/AsyncTest.java fails with An error > of type -10810 has occurred. [v3] Changes requested by asemenyuk (Reviewer). test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TKit.java line 1249: > 1247: static Optional<Boolean> getConfigBooleanProperty(String > propertyName) { > 1248: return Optional.ofNullable(getConfigProperty(propertyName)) > 1249: .map(String::strip) Why do we need to strip whitespace? test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TKit.java line 1258: > 1256: throw new > IllegalArgumentException(String.format( > 1257: "Invalid value of > -Djpackage.test.%s=%s. Expected: true or false", > 1258: propertyName, > getConfigProperty(propertyName))); throw new IllegalArgumentException(String.format( "Invalid value of property %s: %s. Expected: true or false", getConfigPropertyName(propertyName), v)); ------------- PR Review: https://git.openjdk.org/jdk/pull/31265#pullrequestreview-4377321279 PR Review Comment: https://git.openjdk.org/jdk/pull/31265#discussion_r3314867613 PR Review Comment: https://git.openjdk.org/jdk/pull/31265#discussion_r3314864151
