> Previously, the test expected a precise match between the produced and
> expected error messages, but such a check fails when the test fails for
> more than the expected reason, like when WiX is not available on
> Windows.   With this patch, specific test cases that require WiX are
> skipped when WiX is unavailable.  To probe if WiX is available, we use
> reflection to call `jdk.jpackage.internal.WixTool.createToolSet()` and
> check whether the call resulted in an `InvocationTargetException`.  The
> reason for using reflection as opposed to a static reference is that the
> `WixTool` package exists only in the Windows builds.
> 
> Validated this patch on a Windows box that doesn't have WiX available.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Ashay Rane has updated the pull request incrementally with one additional 
commit since the last revision:

  Apply suggested fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/31282/files
  - new: https://git.openjdk.org/jdk/pull/31282/files/3a806d36..a34c8639

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=31282&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=31282&range=01-02

  Stats: 77 lines in 1 file changed: 28 ins; 42 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/31282.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/31282/head:pull/31282

PR: https://git.openjdk.org/jdk/pull/31282

Reply via email to