On Wed, 3 Jun 2026 18:03:03 GMT, Xueming Shen <[email protected]> wrote:

>> This fixes a regression from JDK-8377070 where `ImageResourcesTree` treated 
>> every image entry path as a package hierarchy. That implicitly assumes 
>> directory path segments cannot contain `.`, which is true for package paths 
>> but not for ordinary resources such as 
>> `META-INF/maven/com.google.code.findbugs/...`.
>> 
>> The fix handles non-preview `META-INF/` entries as resource paths, 
>> preserving their directory names as-is and avoiding package inference for 
>> those resources. `META-INF/preview/` continues to use the existing 
>> package-oriented handling because those entries represent preview 
>> class/package content.
>> 
>> A regression test was added to `ImageReaderTest` with `META-INF` resources 
>> containing dotted path segments, verifying resource lookup and directory 
>> contents in both preview-enabled and preview-disabled modes.
>> 
>> This change was developed by @david-beaumont.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Xueming Shen has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update to improve collision

Good.

I assume you'll run at least tier1 + tier2 before integraing.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/31318#pullrequestreview-4421570817

Reply via email to