On Fri, 5 Jun 2026 16:42:20 GMT, Sean Mullan <[email protected]> wrote:

>> src/java.base/share/classes/jdk/internal/event/TLSHandshakeEvent.java line 
>> 38:
>> 
>>> 36:     public String cipherSuite;
>>> 37:     public long certificateId;
>>> 38:     public String namedGroup;
>> 
>> Nit: `namedGroup` is being logged right after `cipherSuite`, it will be 
>> consistent to keep the same order here and in 
>> [`src/jdk.jfr/share/classes/jdk/jfr/events/TLSHandshakeEvent.java`](https://github.com/openjdk/jdk/pull/31371/changes#diff-6fcb6ccf38f77d1a943ad82829a7b70a3d28ace92e895897963a474222675ed4)
>
> Fixed in 
> https://github.com/openjdk/jdk/commit/09283ecd827fe2bc8da5236814c838e5faf9b015

We should change the order in 
[src/jdk.jfr/share/classes/jdk/jfr/events/TLSHandshakeEvent.java](https://github.com/openjdk/jdk/pull/31371/changes#diff-6fcb6ccf38f77d1a943ad82829a7b70a3d28ace92e895897963a474222675ed4)
 as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31371#discussion_r3364168222

Reply via email to