On Thu, 11 Jun 2026 13:01:50 GMT, Emanuel Peter <[email protected]> wrote:
>> Fei Gao has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 11 additional commits >> since the last revision: >> >> - Extend the fix to Vector API masked operations >> - Merge branch 'master' into fix-long-redu-regression >> - Add Vector API IR test case >> - Add a VectorAPI micro-benchmark case >> - Merge branch 'master' into fix-long-redu-regression >> - Refine the comments >> - Add an IR test case and one extra benchmark case >> - Merge branch 'master' into fix-long-redu-regression >> - Dropped unrelated changes and added the AvoidMLAChain option to enable >> this optimization selectively on Neoverse cores >> - Merge branch 'master' into fix-long-redu-regression >> - ... and 1 more: https://git.openjdk.org/jdk/compare/3a8a8234...9c38d647 > > src/hotspot/cpu/aarch64/aarch64_vector.ad line 417: > >> 415: if (n->Opcode() != Op_AddVL && n->Opcode() != Op_SubVL) { >> 416: return true; >> 417: } > > Just a question: You converted the assert into a check. Why? Does it not > always hold anymore? Example? I changed it because we now handle masked nodes here: https://github.com/fg1417/jdk/blob/9c38d647596b51f923fbac7667753bbd50bc01ae/src/hotspot/cpu/aarch64/aarch64_vector.ad#L2878-L2884 The predicate is shared across all element types in this path, so we need to filter out the non-long types. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30237#discussion_r3397066996
