On Thu, 18 Jun 2026 14:28:50 GMT, Jorn Vernee <[email protected]> wrote:
>> Per Minborg has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Remove field directly in Thread and VirtualThread >> - Revert old changes > > src/java.base/share/classes/jdk/internal/foreign/ArenaImpl.java line 90: > >> 88: ConfinedSegmentPool.release(session.owner, poolSp); >> 89: } >> 90: session.resourceList.cleanup(); > > Is it important for the release of the pool to be ordered before the resource > list cleanup? Why not just a simpler `super.close();` followed by the pool > release here? (Could you add a comment?) The reason is that the cleanup actions could throw. I will add a comment on that in the code. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31365#discussion_r3450707588
