On Wed, 24 Jun 2026 20:14:33 GMT, Dean Long <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2847 commits: >> >> - Merge branch '8317277' into jep401_sub_review_8317278 >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - 8387024: [lworld] Remove the mention of mutexes from the specification >> text of value classes >> >> Reviewed-by: alanb, dholmes, liach >> - 8387054: [lworld] BACKOUT JDK-8375694 C2: Dead loop constructed with >> CastPP in late inlining >> >> Reviewed-by: dholmes >> - 8386904: [lworld] ProblemList tests that fail due to JDK-8375645 on all >> platforms >> 8387050: [lworld] ProblemList two >> compiler/valhalla/inlinetypes/TestValueClasses.java sub-tests in Xcomp mode >> >> Reviewed-by: dholmes >> - 8386638: [lworld] Port JEP 401 to PPC64 >> >> Co-authored-by: Richard Reingruber <[email protected]> >> Reviewed-by: dbriemann, rrich, lfoltan >> - Merge >> >> Merge jdk-28+3 >> - 8386815: [lworld] Reduce the number of constructors in IdentityException >> >> Reviewed-by: liach, alanb >> - 8386626: [lworld] Only enable valhalla IR tests in >> ScalarReplacementWithGCBarrierTests.java for aarch64 and x86 >> >> Reviewed-by: mhaessig, mchevalier >> - 8386718: [lworld] C2: Integer overflow in arraycopy scaling for flat >> arrays >> >> Reviewed-by: qamai >> - ... and 2837 more: https://git.openjdk.org/jdk/compare/915efc50...5bc36893 > > src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp line 215: > >> 213: void InterpreterMacroAssembler::read_flat_field(Register entry, >> Register obj) { >> 214: call_VM(obj, CAST_FROM_FN_PTR(address, >> InterpreterRuntime::read_flat_field), obj, entry); >> 215: membar(Assembler::StoreStore); > > Suggestion: > > > FlatValuePayload::read does a StoreStore already, so this one looks redundant. Tracking this in [JDK-8386889](https://bugs.openjdk.org/browse/JDK-8386889), along with other platforms and similar redundancy in C1 calls to `Runtime1::load_flat_array`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3473084073
