On Mon, 29 Jun 2026 17:55:06 GMT, Naoto Sato <[email protected]> wrote:

>> Justin Lu has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Review: Add implNote to parse methods
>
> src/java.base/share/classes/java/util/Locale.java line 3344:
> 
>> 3342:          * string using {@link Double#parseDouble(String)}. As a 
>> result, some
>> 3343:          * non-RFC 2616 forms of otherwise in range values, such as 
>> one with a leading
>> 3344:          * sign, may be accepted.
> 
> I'd spell out the accepted deviations explicitly, such as a leading sign,
> more than three fractional digits, and scientific notation

I kept it vague on purpose because I think it is simpler to defer to 
`Double.parseDouble` rather than commit to a concrete list which would mostly 
rehash the lexical syntax rules defined in `Double.valueOf`. For example, I 
would also have to list that hex syntax and floating-point suffixes are 
allowed. What do you think?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31697#discussion_r3493794816

Reply via email to