On Mon, 6 Jul 2026 16:56:40 GMT, Viktor Klang <[email protected]> wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 144 commits: >> >> - Merge branch 'openjdk:master' into JDK-8373118 >> - undo manual padding; filter signals on propagate >> - manual padding >> - Strengthen some orderings >> - weaken an ordering for internal push; randomize lazySubmit >> - Merge branch 'openjdk:master' into JDK-8373118 >> - Better version of previous commit >> - another set of activation tradeoffs >> - More factoring/control experiments >> - Merge branch 'openjdk:master' into JDK-8373118 >> - ... and 134 more: https://git.openjdk.org/jdk/compare/79be204a...fc3f9261 > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2235: > >> 2233: v.source = TRIM_ON_EMPTY; >> 2234: v.phase = vp; >> 2235: U.unpark(v.owner); > > @DougLea Do we need to unpark `v.owner` here? It looks to me like tryTrim is > only ever invoked by the owner. i.e. currentThread() == v.owner? (Or am I > missign something?) Narrator: The unpark was necessary ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28797#discussion_r3531401275
