On Thu, 9 Jul 2026 22:29:19 GMT, April Ivy <[email protected]> wrote:

>> As noted in https://bugs.openjdk.org/browse/JDK-8382841, JVMCI added 
>> annotation access helpers for the libgraal annotation API.
>> 
>> The memberValues accessors were already removed by JDK-8382582, but 
>> AnnotationParser.parseSelectAnnotations was still left public even though 
>> its only remaining caller is AnnotationType in the same package.
>> 
>> This patch makes parseSelectAnnotations package-private again and restores 
>> the original comment describing its package-internal use.
>> 
>> Testing:
>> - `make CONF=windows-x86_64-server-release CONF_CHECK=ignore java.base`
>> - `make CONF=windows-x86_64-server-release CONF_CHECK=ignore test 
>> TEST="test/jdk/java/lang/annotation"`
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> April Ivy has updated the pull request with a new target base due to a merge 
> or a rebase. The incremental webrev excludes the unrelated changes brought in 
> by the merge/rebase. The pull request contains two additional commits since 
> the last revision:
> 
>  - Merge branch 'openjdk:master' into 
> 8382841-remove-annotation-support-backdoor
>  - 8382841: Revert annotation parsing changes from libgraal

@apwril 
Your change (at version 474b1ab874e50e1586a4608370c988819a4f73e9) is now ready 
to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31851#issuecomment-4930201647

Reply via email to