On Fri, 10 Jul 2026 15:58:47 GMT, Emanuel Peter <[email protected]> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Review comments resolution
>
> test/micro/org/openjdk/bench/jdk/incubator/vector/Float16ToIntegralConvBenchmark.java
>  line 53:
> 
>> 51:         bout = new byte[size];
>> 52: 
>> 53:         IntStream.range(0, size).forEach(i -> {fp16inp[i] = 
>> Float.floatToFloat16((float)i);});
> 
> Suggestion:
> 
>         Arrays.setAll(fp16inp, i -> Float.floatToFloat16((float)i));
> 
> Would that not be a bit simpler?

The issue: java.util.Arrays.setAll has no overload accepting a short[]

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30928#discussion_r3569574956

Reply via email to