> A few fail-safe convenience methods added in #23548 are missing necessary 
> null checks. In addition, the `PackageEntry` symbolic conversion and testing 
> methods are not correctly rejecting `PackageDesc` representing the unnamed 
> package, a deliberate choice when `PackageDesc` was added to Java.
> 
> Luckily, these oversights can be easily fixed and verified with minor 
> enhancements to existing tests. There are also accompanying minor doc 
> enhancements about the situation.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Chen Liang has updated the pull request incrementally with one additional 
commit since the last revision:

  Replicable pool states

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/31925/files
  - new: https://git.openjdk.org/jdk/pull/31925/files/f11ee0c2..79abfe7a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=31925&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=31925&range=00-01

  Stats: 22 lines in 1 file changed: 3 ins; 0 del; 19 mod
  Patch: https://git.openjdk.org/jdk/pull/31925.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/31925/head:pull/31925

PR: https://git.openjdk.org/jdk/pull/31925

Reply via email to