On Tue, 10 Oct 2023 14:27:13 GMT, Claes Redestad <[email protected]> wrote:
>> Alternative to #16082
>>
>> Name (unchanged) Cnt Base Error Test
>> Error Unit Change
>> URLEncodeDecode.testEncodeLatin1 0 15 2,066 ± 0,104 1,899 ±
>> 0,007 ms/op 1,09x (p = 0,000*)
>> URLEncodeDecode.testEncodeLatin1 75 15 0,934 ± 0,017 0,811 ±
>> 0,014 ms/op 1,15x (p = 0,000*)
>> URLEncodeDecode.testEncodeLatin1 100 15 0,433 ± 0,060 0,389 ±
>> 0,007 ms/op 1,11x (p = 0,008*)
>> * = significant
>> ```
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add 129, fix erroneous step in clearedAtTheTail
src/java.base/share/classes/jdk/internal/util/ImmutableBitSetPredicate.java
line 71:
> 69: * <p>
> 70: * If the returned predicate is invoked with a {@code bitIndex} that
> is negative, the predicate
> 71: * will throw an IndexOutOfBoundsException just as the {@link
> BitSet#get(int)} method would.
This paragraph is no longer correct, as the predicate now returns `false` for
negative values:
Suggestion:
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16094#discussion_r3619781970
