On Tue, 21 Jul 2026 18:12:54 GMT, Justin Lu <[email protected]> wrote:
>> src/java.base/share/classes/java/text/DecimalFormat.java line 2765: >> >>> 2763: return isGroupingUsed() && groupingSize > 0; >>> 2764: } >>> 2765: >> >> "Relevant" sounds a bit vague here. Since this checks whether grouping is >> effectively enabled (`isGroupingUsed()` and a positive grouping size), how >> about `isGroupingEnabled()`? >> >> Also, I think you meant "lenient" instead of "legacy" at the last comment >> line. > > Yeah I agree `enabled` is better. I actually did mean to use "legacy" there > to explain **why** the lenient parsing behavior did not validate grouping > size. (Since there was no reason other than it being long standing legacy > behavior.) Then I think we should clarify that “legacy parsing” refers to "lenient parsing". "Strict parsing" was introduced later, so lenient parsing preserves the original behavior. That relationship may not be immediately obvious to readers. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31980#discussion_r3625040382
