On Tue, 21 Jul 2026 17:19:00 GMT, Sandhya Viswanathan <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments resolution > > src/hotspot/cpu/x86/x86.ad line 24954: > >> 24952: int vlen_enc = vector_length_encoding(this); >> 24953: __ evfmadd231ph($dst$$XMMRegister, $src2$$XMMRegister, >> $src1$$Address, vlen_enc); >> 24954: %} > > We should add the predicate: > predicate(Matcher::vector_length_in_bytes(n->in(1)) > 8); > > Also a nit: > It reads weird to have the order as src2, src1 instead of src1, src2. > Let us have the match rule as: > match(Set dst (FmaVHF dst (Binary src1 (VectorReinterpret (LoadVector > src2))))); > and the corresponding changes below. Addressed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31724#discussion_r3642994605
