On Thu, 16 Jul 2026 11:51:04 GMT, Emanuel Peter <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments resolution > > test/micro/org/openjdk/bench/jdk/incubator/vector/Float16VectorFMAAccumBenchmark.java > line 69: > >> 67: // tile. At this tile size the 132-form (result tied to a >> multiplicand) >> 68: // overflows the ZMM register file and spills to the stack, whereas >> the >> 69: // 231-form accumulates in place. > > That sounds neat! > Could we have some sort of IR test that would check we don't get spills? > Just so we don't accidentally get regressions. We probably will rarely to > never rerun such micro benchmarks, and so we would maybe not easily detect if > we broke this. Addressed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31724#discussion_r3642994938
