On Thu, 23 Jul 2026 21:47:22 GMT, Justin Lu <[email protected]> wrote:
>> Ensure that the implementation does not generate subsequent warnings for >> each row exceeded above the maximum allowed. >> >> Additional fixes included >> - `crs` created via hashtable c-tor no longer throws `NPE` when its warning >> is referenced. >> - 2-arg `populate` uses `setWarning` with a `RowSetWarning` which fixes the >> issue when the warning was polled by client and an `Error` occurred, because >> `setException` does not expect an `SQLException` >> - Root warning is no longer a pointless blank warning. The root warning now >> always contains a valid warning message. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/java.sql.rowset/share/classes/com/sun/rowset/CachedRowSetImpl.java line > 6818: > >> 6816: private void addRowSetWarning(String reason) { >> 6817: if (rowsetWarning == null) { >> 6818: rowsetWarning = new RowSetWarning(reason); > > Although I consider it a bug that the root warning was always empty in the > original code, I can revert this change to the original behavior if we think > there is risk. This should be fine ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32033#discussion_r3646536701
