On Mon, 27 Jul 2026 16:10:12 GMT, Arno Zeller <[email protected]> wrote:
> > My concern is more about changing all the jlink tests. The test for, e.g. > > including locales, shouldn't be using .--strip-debug. Same thing for many > > other tests. > > The update the plugin is fine but if disk space during test runs is an > > issue it would be better to have the tests do cleanup and delete the > > generated run-time images when the test passes. If they are generated into > > the jtreg scratch directory then they should be cleaned up already. > > The problem is that we execute the jtreg tests with agents and a concurrency > of 16 - this causes up to 16 concurrent running jlink tests. When each test > creates an image of 1.3 GB that would lead to 21 GB of peak disk usage - but > several tests need to create more than one image at runtime. I’ve now run several `tools/jlink` test runs, all using a concurrency level of 16 with a fastdebug build (GCC 14.2.0) that contains a 1.3 GB `libjvm.debuginfo` file. Without any changes, I observe a peak disk usage of approximately 50 GB. With this change applied, peak disk usage drops to about 21 GB. If I apply this change but remove `--strip-debug` changes, peak disk usage is around 25 GB. Given the relatively small difference, I think it is reasonable to remove the `--strip-debug` changes and avoid adding extra test-specific statements that would otherwise clutter the tests. ------------- PR Comment: https://git.openjdk.org/jdk/pull/32009#issuecomment-5104025146
