On Tue, 28 Jul 2026 15:00:06 GMT, Matthias Baesken <[email protected]> wrote:

> The windows relauncher.c has some unused local variable that should be 
> removed.
> And the PROCESS_INFORMATION used in the coding needs some init step 
> additional to just zeroing it.
> See
> https://learn.microsoft.com/en-us/windows/win32/procthread/creating-processes
> where the usage of PROCESS_INFORMATION with CreateProcess is described.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Good (modulo the requested title/description change by David). 

There is a slight chance that the change will result in behavioral change: 
before, cbsize was 0, so it is possible the structure was ignored by 
CreateProcess. Now it would not be ignored.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/32071#pullrequestreview-4804615716

Reply via email to