On Tue, 28 Jul 2026 16:22:04 GMT, Alan Bateman <[email protected]> wrote:
> Thanks. I've edited it so that it's more in the style of other CSRs. Thanks for updating the CSR. I noticed that `--enable-final-field-mutation` was missing from the list, so I added it to the CSR as it is also covered by this change. > We could potentially re-visit IsModuleOption and IsLongFormModuleOption so > they aren't just for module options. The only special thing is the mapping of > -p to its long form. Do you mean merging these options into a more general helper for long options that accept whitespace-separated arguments? I used a separate helper because options recognized by `IsModuleOption` and `IsLongFormModuleOption` trigger the dedicated `ARG_ERROR6` diagnostic when their arguments are missing. Adding non-module options to these helpers would therefore produce an inappropriate error message. https://github.com/openjdk/jdk/blob/cc1238890c984ac3c23690add22c5f2feaa9e395/src/java.base/share/native/libjli/java.c#L1250-L1251 ------------- PR Comment: https://git.openjdk.org/jdk/pull/31928#issuecomment-5118521380
