On Tue, 28 Jul 2026 15:00:06 GMT, Matthias Baesken <[email protected]> wrote:
> The windows relauncher.c has some unused local variable that should be > removed. > And the STARTUPINFO used in the coding needs some init step additional to > just zeroing it. > See > https://learn.microsoft.com/en-us/windows/win32/procthread/creating-processes > where the usage of STARTUPINFO with CreateProcess is described. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). I also wondered about how `createProcess` may actually use this ... the documentation is far from clear. The structure seems to have a clearly defined static size so I don't know why we would need to set the `cb` field to show that - unless zero is used as a way to say "don't use this"? But according to one of the docs [1]: > The dwFlags member contains a bitfield that determines which other members of > the structure are used. so as long as dwFlags is zero it seems it should be ignored. [1] https://learn.microsoft.com/en-us/windows/win32/procthread/setting-window-properties-using-startupinfo ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/32071#pullrequestreview-4814840815
