On Fri, 31 Jul 2026 11:21:02 GMT, Alan Bateman <[email protected]> wrote:

>> Chen Liang has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Wording review from Joe
>
> src/java.base/share/classes/java/lang/Class.java line 912:
> 
>> 910:      * #isHidden() hidden classes}, {@linkplain #getEnclosingClass() 
>> enclosing
>> 911:      * classes}, {@linkplain #getNestMembers() nest members}, only 
>> apply to
>> 912:      * classes and interfaces.
> 
> The first sentence of the method description is good. 
> 
> I'm less sure about the rest of the paragraph, esp.  the term "reflective 
> concepts" as it appears out of thin air. Is this really needed? I don't see a 
> need to say anything about hidden classes here (Joe's comment is addressed by 
> having "class or interface" in the Hidden Classes section link to the 
> method).  The method could say that it returns false for primitive and array 
> classes as that is a question that potential users of this API will wonder 
> about.

To clarify the mutually exclusive relationships between classes and interfaces, 
array types, and primitive types (and void), I added a word anchor "reference 
type" in `isPrimitive()` and briefly described its structure.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32109#discussion_r3691617829

Reply via email to