On Fri, 31 Jul 2026 10:30:40 GMT, Alan Bateman <[email protected]> wrote:
>> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback, expand number of interfaces updated. > > src/java.base/share/classes/java/util/function/DoubleSupplier.java line 40: > >> 38: * java.util.function##functionsAndNull null handling policy} for >> 39: * interfaces in this package. >> 40: * > > Int/Long/DoubleSupplier conforms to the policy but it is a bit confusing to > say this when there are no parameters and the return value is a primitive. So > I think I would be tempted to drop the update to the specialized suppliers. In its final state, I would expect this patch to include some update (almost) all of the interfaces in `java.util.function`. Across the collection of types, I think that is the least confusing state. For the ones where the policy isn't really relevant, such as DoubleSupplier, I was hoping the "(vacuously)" would convey the needed disclaimer. > src/java.base/share/classes/java/util/function/package-info.java line 120: > >> 118: * implementations of the interfaces. Therefore, unless otherwise >> 119: * specified for arguments and return values that have a reference >> 120: * type, arguments to methods may be null and the the return value may > > the the Fixed; thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32111#discussion_r3691948750 PR Review Comment: https://git.openjdk.org/jdk/pull/32111#discussion_r3691936188
