> `VerifyStackChunkFrameClosure` calls `StackChunkFrameStream::frame_size` to 
> compute the sizes of frames stored in the `stackChunk`, but that method 
> incorrectly uses `cb()->frame_size()` for extended compiled frames. The 
> actual frame size has to be read from the frame metadata recorded when the 
> frame was extended.
> 
> Thanks to @TobiHartmann for the small reproducer which I included in the PR. 
> I also tested the fix running `TestVirtualThreads.java` and `Fuzz.java` with 
> `-XX:+VerifyContinuations` which also triggered the same assert before this 
> fix.
> 
> Thanks,
> Patricio
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Patricio Chilano Mateo has updated the pull request incrementally with three 
additional commits since the last revision:

 - fix copyright header
 - addd extra @test with -XX:+VerifyContinuations
 - fix assert

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/32178/files
  - new: https://git.openjdk.org/jdk/pull/32178/files/5bfce418..b3c9fa49

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=32178&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=32178&range=00-01

  Stats: 42 lines in 6 files changed: 33 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/32178.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/32178/head:pull/32178

PR: https://git.openjdk.org/jdk/pull/32178

Reply via email to