On Tue, 4 Aug 2026 18:48:55 GMT, Mohamed Issa <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >> commits since the last revision: >> >> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8382523 >> - Review comments resolution >> - Review comments resolution >> - Review comments resolution >> - Review comments resolution >> - Review comments resolution >> - 8382523: Optimize Float16 to integral conversion operations for >> AVX512-FP16 targets > > src/hotspot/cpu/x86/assembler_x86.cpp line 2375: > >> 2373: } >> 2374: >> 2375: void Assembler::evcvttph2dq(XMMRegister dst, XMMRegister src, int >> vector_len) { > > Please move evcvttph2dq and evcvttph2qq definitions to be just after > vcvttps2dq definition. That way the two evcvttps2dqs definitions stay next to > each other. Addressed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30928#discussion_r3717997911
