On Wed, 5 Aug 2026 10:38:12 GMT, ExE Boss <[email protected]> wrote: >> Marc Chevalier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Also a normal range for testing > > src/hotspot/share/opto/inlinetypenode.cpp line 1055: > >> 1053: Node* la = make_load(offset, TypeLong::LONG, T_LONG); >> 1054: result = kit->AddI(kit->MulI(thirty_one, result), >> kit->ConvL2I(la)); >> 1055: result = kit->AddI(kit->MulI(thirty_one, result), >> kit->ConvL2I(kit->URShiftL(la, kit->intcon(32)))); > > Note that as was suggested in > <https://github.com/openjdk/jdk/pull/31123#discussion_r3354053360> (and > [JDK‑8388062]), this and `ValueObjectMethods::valueObjectHashCode(…)` should > probably be updated to use the same computation as `Long::hashCode`. > > [JDK‑8388062]: https://bugs.openjdk.org/browse/JDK-8388062
That's true! But that is a discussion that would involve people with more stake (and rightfully stronger opinions) than me. And I suspect changing how the hash is computed is not a priority for those people as long as the current version is good enough (which is very understandable!). Since it would be easy to change the compiler parts if needed, it was decided not to block this PR on a decision that is not likely to come very quickly. Also I don't think it'd be very nice to both add the compiler improvements at the same time as a modification in the behavior. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32144#discussion_r3720384100
