On Wed, 12 Aug 2026 15:55:14 GMT, Matias Saavedra Silva <[email protected]> wrote:
>> When performing an AOT training run using a multi-release JAR file, the >> following warning can be encountered: >> `[warning][aot] class org/example/Foo cannot be archived because it was not >> defined from <path to mr.jar> as claimed` >> This warning results from a specific configuration of the JAR file where the >> class is not in the root directory but is present in the versioned directory >> `META-INF/version`. To fix this, an upcall to ClassLoader.getResource() is >> now made in the specific case where a multi-release JAR is being used and >> the class cannot be found through normal means. Verified with tier 1-5 tests. >> >> >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matias Saavedra Silva has updated the pull request incrementally with one > additional commit since the last revision: > > Ioi offline comments Just a couple of comments about the code, not really a review. src/hotspot/share/classfile/classLoader.cpp line 392: > 390: oop zip_name_oop = CDSProtectionDomain::to_file_URL(_zip_name, > Handle(), current); > 391: Handle h_class_name = Handle(current, class_name_oop); > 392: Handle h_zip_name = Handle(current, zip_name_oop); nit, you can declare these as: Handle h_class_name(current, name_oop); Handle h_zip_name(current, zip_name_oop); ------------- PR Review: https://git.openjdk.org/jdk/pull/32087#pullrequestreview-4919411328 PR Review Comment: https://git.openjdk.org/jdk/pull/32087#discussion_r3768846339
