On Wed, 12 Aug 2026 18:22:12 GMT, Brent Christian <[email protected]> wrote:
>> Guanqiang Han has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add missing comma > > test/jdk/java/lang/Object/FinalizationOption.java line 123: > >> 121: return; >> 122: } >> 123: > > Updating `main()` like this seems unnecessary. > Can't this be done just by adding a couple `@run` options? > E.g.: > > * @run main/othervm --finalization enabled FinalizationOption yes > * @run main/othervm --finalization disabled FinalizationOption no Thanks for the suggestion. I used `ProcessTools.executeTestJava()` because `@run main/othervm --finalization enabled FinalizationOption yes` would cause jtreg to treat `enabled` as the test class, so the whitespace-separated form needs to be launched explicitly here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31928#discussion_r3771616295
