On Mon, 17 Aug 2026 09:41:01 GMT, Markus Grönlund <[email protected]> wrote:

>> Greetings,
>> 
>> Please see the problem description and rationale in the JIRA issue.
>> 
>> Testing: jdk_jfr, stress testing, tier1 - 6
>> 
>> Thanks
>> Markus
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Markus Grönlund has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   change reinterpret_cast to static_cast

The JBS description of the problem and solution no longer matches what is 
actually being done. I really don't understand the changes being made.

src/hotspot/share/classfile/vmClasses.cpp line 274:

> 272:   Dictionary* dictionary = loader_data->dictionary();
> 273:   dictionary->add_klass(THREAD, klass->name(), klass);
> 274: 

Why the reordering of the adding to the dictionary here?

-------------

PR Review: https://git.openjdk.org/jdk/pull/32218#pullrequestreview-4956299185
PR Review Comment: https://git.openjdk.org/jdk/pull/32218#discussion_r3800277651

Reply via email to